Fixes issue #1029 #1235
Merged
Fixes issue #1029 #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #1029 (bucket duplication in the magician's workbench), which was readily reproducible when making cake on the first source release. My fix was to remove the check about whether container items should stay in the inventory and to just replace them where they sit - duplicate buckets are therefore not stuffed into the player's inventory and mass is conserved.
A perfect fix would move the excess container items to the workbench's inventory, the players inventory or the space under the player's nose if both are full, and I can see a way to implement that, but I'll have to come back to that when I get more time after looking at the rest of the bugs.