refactor: Use Typescript for editor compiler #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: Use ts for linter and related files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges into #490
This PR refactors all compiler utils to typescript. This is all the files that are in src/utils/compiler. There's still a couple of compiler-adjacent files that still need to be refactored.
I've added various types for several of the editor functions like Mixins and Parameters objects, which should make these a lot easier to decipher. Previously it took some parsing to understand what a variable or function used or returned, but this refactor should make it much easier to understand.
While changing types I also refactored some code to be more readable, but this was kept to a minimum. Mostly consisting of some new lines or early returns here and there.