Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance "Filter Notes by Keywords" and English Language Support #1

Closed
UsmanTechJive opened this issue Nov 10, 2024 · 7 comments
Closed

Comments

@UsmanTechJive
Copy link

The "Filter Notes by Keywords" feature currently does not support case-insensitive searches, which limits its usability. Additionally, it does not search within sub-documents inside a notebook. Also I would request you to please add English language support.

Steps to Reproduce:

  • Create a notebook named "Dev".
  • Attempt to search using the keyword "dev".
  • Observe that the search does not return the expected results.
  • Attempt to search for keywords within sub-documents of the notebook.

image

image

Expected Behavior:

  • The search should be case-insensitive, returning results for both "Dev" and "dev".
  • The search should include results from sub-documents within the notebook.

Actual Behavior:

  • The search is case-sensitive, only returning results for the exact case.
  • The search does not include sub-documents.

Proposed Solution:

  • Implement case-insensitive search functionality.
  • Extend the search to include sub-documents within notebooks.
@Misuzu2027
Copy link
Owner

Great suggestions! Both of these features can be implemented.

However, I have a question regarding extending the search range. If sub-documents are matched, should we hide the documents under that notebook that do not match?

The benefit of hiding them is that it allows for quicker navigation when the list is long. The downside is that it makes development more challenging, as expanding and collapsing the directory would dynamically refresh the document list.

Misuzu2027 added a commit that referenced this issue Nov 10, 2024
@Misuzu2027
Copy link
Owner

v0.0.3 has been updated:

  • Document tree query now ignores keyword case sensitivity
  • Supports matching document names under notebooks (requires enabling in settings)

The multilingual English version will be added when time allows in the future.

@UsmanTechJive
Copy link
Author

However, I have a question regarding extending the search range. If sub-documents are matched, should we hide the documents under that notebook that do not match?

Yes, it should hide the documents under that notebook that do not match; this would be great but also bit challenging as well. See what you can do about this; if it's possible, that would be great.

Also, please support English in future updates. Thanks! 🙏

Misuzu2027 added a commit that referenced this issue Nov 16, 2024
#1 : 支持国际化+文档树搜索过滤不想干文档
#2 : 文档树搜索框支持清空
@Misuzu2027
Copy link
Owner

v0.0.4 Updated

@UsmanTechJive
Copy link
Author

UsmanTechJive commented Nov 16, 2024

Thank you for the update. I appreciate that.

I just have one request: could you please improve the search so that once it finds a match inside the notebook, it automatically display subnotes? currently I have to click on the arrow to show them manually.

Recording.2024-11-16.151611.mp4

@Misuzu2027
Copy link
Owner

Thank you for the suggestion.

However, this feature is currently difficult to implement because the official API does not provide an interface for locating a specific document in the document tree. Therefore, we are unable to update this feature for now.

@Misuzu2027
Copy link
Owner

If you frequently search for documents and don't mind the document structure, you might consider using the Document Search plugin. It includes a "Flat Document Tree Dock" feature that allows you to quickly locate the desired document and supports full-text search within documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants