Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix weird color issue (#14) #22

Merged
merged 1 commit into from
Jan 14, 2021
Merged

fix weird color issue (#14) #22

merged 1 commit into from
Jan 14, 2021

Conversation

loiccoyle
Copy link
Contributor

@loiccoyle loiccoyle commented Jan 13, 2021

Hi again,

This should fix #14 , it seems it is an issue with the alpha channel, so I basically convert the image to rgba format regardless of it has one and provide the ColorFormat::Rgba format.
Keep in mind I basically have no rust experience so if I mishandled anything please let me know.

Before: https://imgur.com/a/U8Aa0kR

After: https://imgur.com/3q2A2lw

As far as I can tell this doesn't break anything, but please try it out.

@Misterio77 Misterio77 merged commit 22d4e7f into Misterio77:master Jan 14, 2021
@Misterio77
Copy link
Owner

Thanks for the fix!

@Misterio77
Copy link
Owner

Misterio77 commented Jan 14, 2021

I'll be sure to test this with my images to make sure schemes generated from images that previously worked don't change (too much).

I should refactor the code asap to include automatic tests for future pulls, though. I'm a lot better at Rust than i used to be when i wrote flavours, so there's a lot of improvements to be done.

Thanks again for catching and fixing this!

@Misterio77
Copy link
Owner

Misterio77 commented Jan 14, 2021

It seems the changes are pretty minor. The trim colors differ a bit (mostly just the order is changed), and sometimes one or another is swapped (probably happens because of the color fixing code). Nothing that should break people's setup anyway (unless they actively depend on color order... which i think no one does lol).

Will try and see if i can include more improvements to release together with this on 0.4, but if it takes too long i will just release this with 0.3.5

@loiccoyle
Copy link
Contributor Author

Perfect, thanks a lot!

@loiccoyle loiccoyle deleted the fix_#14 branch January 14, 2021 12:32
@Misterio77
Copy link
Owner

Sorry for the delay, getting this new version release right now.

@loiccoyle
Copy link
Contributor Author

No worries !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generated color scheme gives some weird colors
2 participants