Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(Page): ページを非公開にできるように #821

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

mattyatea
Copy link
Member

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link
Member

@u1-liquid u1-liquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非公開のことをpublishって呼ぶのは違う気がする
既にvisibilityフィールドがあるのでそれをdropせずにpublic/privateで扱ってほしい
frontendのpageの一覧で見分けがつかないので非公開状態のpageは非公開ってラベルを付けてほしい

@mattyatea
Copy link
Member Author

UIはこんな感じです
image
image
image
image

@mattyatea
Copy link
Member Author

あとPageの中とPagePreviewでタイトルの表示に差異があるのが気になったので直してます
image

@u1-liquid u1-liquid changed the title Enhance(Page): ページを非公開にできるように enhance(Page): ページを非公開にできるように Dec 7, 2024
locales/index.d.ts Outdated Show resolved Hide resolved
locales/ja-JP.yml Outdated Show resolved Hide resolved
mattyatea and others added 2 commits December 8, 2024 05:10
Co-authored-by: あわわわとーにゅ <[email protected]>
Co-authored-by: あわわわとーにゅ <[email protected]>
Copy link

sonarcloud bot commented Dec 7, 2024

@u1-liquid u1-liquid merged commit 1a81d3f into MisskeyIO:io Dec 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants