Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation in French #94

Closed
wants to merge 1 commit into from
Closed

Translation in French #94

wants to merge 1 commit into from

Conversation

alexbelgium
Copy link
Contributor

@alexbelgium alexbelgium commented Apr 10, 2022 •
edited
Loading

@MislavMandaric
Copy link
Owner

MislavMandaric commented Apr 11, 2022 •
edited
Loading

Hey @alexbelgium

My PR #97 which adds reauth flow is now merged.

Can you please rebase your changes and update the translations to match the new structure?

EDIT: Also, can you please follow the following naming convention for commits:

feat: Description for features
fix: Description of bugfix

I have an automated versioning set up using semantic release and it depends on proper commit naming for it to work.

@MislavMandaric MislavMandaric self-requested a review April 11, 2022 20:13
@alexbelgium
Copy link
Contributor Author

Thanks! I'll make sure to do that for next commits. I'll rebase tomorrow

@alexbelgium
Copy link
Contributor Author

Creating a new pull request to follow commits semantic

@alexbelgium alexbelgium deleted the patch-1 branch April 11, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MislavMandaric MislavMandaric Awaiting requested review from MislavMandaric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbelgium @MislavMandaric