-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to SQLite 3.30; Django 2.2 requires at least SQLite 3.8.3. #106
base: master
Are you sure you want to change the base?
Conversation
…t/greatest version.
@FlipperPA did you ever get this working? I for the life of me can't. |
@youcandanch I'm going to give it another whirl next week. I had it working locally, and wanted to test it as part of Lambda packages, but now it doesn't appear to be working from local. I'm wondering if I missed something, or something was cached. I'll look into it more deeply next week. |
I finally got some time to look at this. It turns out we need to build a full https://charlesleifer.com/blog/compiling-sqlite-for-use-with-python-applications/ This created a much, much larger binary (which makes sense), because it should contain all of SQLite. I've successfully pushed out the binary and have it responding from AWS Lambda with version 3.30:
Anyone else care to test? @youcandanch? |
@Miserlou @mcrowson @jneves This is now ready to be merged. I've got it running in dev and production on my site at https://pyphilly.org/ with the latest Django and Wagtail versions. Huzzah! |
If anyone is waiting for this, in the meantime, feel free to use this: https://github.com/FlipperPA/django-s3-sqlite |
Is there any progress in merging this? |
@vaivars It is unlikely this will every be merged in. You can use https://github.com/FlipperPA/django-s3-sqlite which is now more advanced, with quite a few more checks to help avoid (but not eliminate) race conditions. |
UPDATE: this is unlikely to ever be merged in. Please use the more modern version here: https://github.com/FlipperPA/django-s3-sqlite
This upgrades to the latest/greatest version.
Django 2.2 deploys using SQLite (or the Zappa Django Utils s3sqlite engine) will fail, because the current package is SQLite 3.6.0.
Cheers!