Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NetworkReader ReadBytes/Array<T>/List<T> allocation limit to prevent ClientToServer [SyncVar] allocation attacks [credit: James] #3562

Merged
merged 12 commits into from
Jul 27, 2023
Merged

fix: NetworkReader ReadBytes/Array<T>/List<T> allocation limit to prevent ClientToServer [SyncVar] allocation attacks [credit: James] #3562

merged 12 commits into from
Jul 27, 2023

Commits on Jul 27, 2023

  1. fix: NetworkReader.ReadArray: remove misleading 'length > reader.Rema… 

    …ining' check since not all arrays are byte arrays
    mischa committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    b97218d View commit details
    Browse the repository at this point in the history

  2. fix: NetworkReader AllocationLimit to prevent ClientToServer [SyncVar… 

    …] allocation attacks [credit: James]
    mischa committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    330ed5f View commit details
    Browse the repository at this point in the history

  3. ReadBytes: check allocation limit

    mischa committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    39924cb View commit details
    Browse the repository at this point in the history

  4. ReadList: check allocation limit

    mischa committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ca51c37 View commit details
    Browse the repository at this point in the history

  5. ReadArray: check allocation limit

    mischa committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    cb43ca0 View commit details
    Browse the repository at this point in the history

  6. ReadTexture2D: check allocation limit

    mischa committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    5bcd2a4 View commit details
    Browse the repository at this point in the history

  7. limit as count

    mischa committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d61f849 View commit details
    Browse the repository at this point in the history

  8. writer checks

    mischa committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    0de02d3 View commit details
    Browse the repository at this point in the history

  9. test wip

    mischa committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    2ce63f3 View commit details
    Browse the repository at this point in the history

  10. throw

    mischa committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    2e47d46 View commit details
    Browse the repository at this point in the history

  11. add test

    mischa committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    2426507 View commit details
    Browse the repository at this point in the history

  12. test

    mischa committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d67e01c View commit details
    Browse the repository at this point in the history