Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MrGadget NetworkManager populate spawnable prefabs button suggestions #3619

Closed
miwarnec opened this issue Oct 2, 2023 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@miwarnec
Copy link
Collaborator

miwarnec commented Oct 2, 2023

posting so it doesn't get lost.

Few suggestions:

  1. Do the OrderBy on the identities list before doing the AddRange, so that any that were added to NM.spawnable manually first are kept in place
  2. Add a Clear button so users can wipe the list and rescan to rebuild the list fully sorted if they know that won't break them
  3. make sure you're not adding Player Prefab to spawnables, since Mirror adds that automatically elsewhere.

For no. 1 above, I'm thinking of the case where player character prefabs are intentionally put in the first few slots and referenced by index in char selection, so they can't be sorted down into the middle of the list without breaking things

@miwarnec miwarnec added the enhancement New feature or request label Oct 2, 2023
@miwarnec
Copy link
Collaborator Author

miwarnec commented Oct 8, 2024

clear button:
image

@miwarnec
Copy link
Collaborator Author

miwarnec commented Oct 8, 2024

as for OrderBy: this goes both ways:

  • some users may prefer the original prefabs to stay unordered, followed by ordered
  • otherwise may prefer the whole list to be ordered

I think it's more likely that people want everything to be ordered, since the Populate button is meant to add Everything.

@miwarnec
Copy link
Collaborator Author

miwarnec commented Oct 8, 2024

#3915

@miwarnec miwarnec closed this as completed Oct 8, 2024
MrGadget1024 added a commit that referenced this issue Oct 8, 2024
* feat(NetworkManager): Clear Spawnable Prefabs button (#3619)

* Update Assets/Mirror/Editor/NetworkManagerEditor.cs

Co-authored-by: MrGadget <[email protected]>

---------

Co-authored-by: mischa <[email protected]>
Co-authored-by: MrGadget <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant