Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sudo on newer distros #370

Merged
merged 1 commit into from
May 18, 2022
Merged

Fix sudo on newer distros #370

merged 1 commit into from
May 18, 2022

Conversation

kke
Copy link
Collaborator

@kke kke commented May 16, 2022

Fixes #369

The sudo on newer distros such as Jammy do not accept something like:

sudo -s -- FOO=bar env

and error out with: FOO=bar: command not found.

The correct syntax, even for older sudos is:

sudo -s FOO=bar -- env`

The actual change has been implemented in k0sproject/rig#60

@kke kke requested a review from quadespresso May 16, 2022 10:50
Copy link
Contributor

@quadespresso quadespresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be missing the effective change to the sudo command here, but I'm only seeing changes to the 2 files go.mod and go.sum...?

@kke
Copy link
Collaborator Author

kke commented May 17, 2022

I may be missing the effective change to the sudo command here, but I'm only seeing changes to the 2 files go.mod and go.sum...?

Yes because the actual change is made in rig k0sproject/rig#60

Copy link
Contributor

@quadespresso quadespresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@kke kke merged commit 1c1d07e into master May 18, 2022
@kke kke deleted the fix-sudo branch May 18, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu installs fail with DEBIAN_FRONTEND=noninteractive: command not found
2 participants