Skip to content

Commit

Permalink
PRODENG-2568 fix mke upgrade %!s(MISSING)
Browse files Browse the repository at this point in the history
- error reported by RBC
- incorrect fmt argument handling in upgrade_mke phase

Signed-off-by: James Nesbitt <[email protected]>
  • Loading branch information
james-nesbitt committed Mar 12, 2024
1 parent f31ba77 commit 882370b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/product/mke/phase/upgrade_mke.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ func (p *UpgradeMKE) Run() error {
if swarmLeader.Configurer.SELinuxEnabled(swarmLeader) {
runFlags.Add("--security-opt label=disable")
}
upgradeCmd := swarmLeader.Configurer.DockerCommandf("run %s %s upgrade %s %s", runFlags.Join(), p.Config.Spec.MKE.GetBootstrapperImage(), upgradeFlags.Join())

log.Debugf("%s: upgrade flags: %s", swarmLeader, upgradeFlags.Join())
upgradeCmd := swarmLeader.Configurer.DockerCommandf("run %s %s upgrade %s", runFlags.Join(), p.Config.Spec.MKE.GetBootstrapperImage(), upgradeFlags.Join())
err := swarmLeader.Exec(upgradeCmd, exec.StreamOutput())
if err != nil {
return fmt.Errorf("%s: failed to run MKE upgrader: %w", swarmLeader, err)
Expand Down

0 comments on commit 882370b

Please sign in to comment.