Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages with high CVE issues #192

Merged
merged 4 commits into from
Jun 8, 2023

Conversation

nwneisen
Copy link
Collaborator

This updates packages to fix the CVEs reported in #191

Running the scanner with these changes shows the reported CVEs are fixed.

(MKE-9731-fix-cves): trivy repo --branch MKE-9731-fix-cves https://github.com/nwneisen/cri-dockerd
2023-05-31T13:50:33.866-0600    INFO    Vulnerability scanning is enabled
2023-05-31T13:50:33.866-0600    INFO    Secret scanning is enabled
2023-05-31T13:50:33.866-0600    INFO    If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2023-05-31T13:50:33.866-0600    INFO    Please see also https://aquasecurity.github.io/trivy/v0.41/docs/secret/scanning/#recommendation for faster secret detection
Enumerating objects: 6990, done.
Counting objects: 100% (6990/6990), done.
Compressing objects: 100% (4675/4675), done.
Total 6990 (delta 2210), reused 5571 (delta 1894), pack-reused 0
2023-05-31T13:50:46.560-0600    INFO    Number of language-specific files: 1
2023-05-31T13:50:46.560-0600    INFO    Detecting gomod vulnerabilities...

@neersighted
Copy link
Contributor

Looks like go mod vendor got missed 😅

@nwneisen nwneisen marked this pull request as ready for review May 31, 2023 20:25
Copy link
Contributor

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is going to require some code changes for API movement; however skimming through the new vendor there's nothing that jumps out at me as being ripe for regressions.

libdocker/kube_docker_client.go Outdated Show resolved Hide resolved
libdocker/kube_docker_client.go Outdated Show resolved Hide resolved
@neersighted
Copy link
Contributor

Looks like there's still some test failures to dig into related to seccomp profiles.

@nwneisen
Copy link
Collaborator Author

nwneisen commented Jun 6, 2023

This looks like an error with the integration action in general. The same failure is happening on all of the other open PRs and master 👀

@neersighted
Copy link
Contributor

Ah, good catch. I think we will have to follow-up on that later than. If the failures are not new, LGTM 👍

@nwneisen
Copy link
Collaborator Author

nwneisen commented Jun 6, 2023

It looks like master previously passed and rerunning it now fails due to this issue. So this is a new issue with integration. I'm going to hold off on merging this and take a look at the problem now and I will open a fix in another PR

@nwneisen nwneisen force-pushed the MKE-9731-fix-cves branch from c8fc4fa to fe87571 Compare June 7, 2023 23:04
@nwneisen nwneisen merged commit 6f4e576 into Mirantis:master Jun 8, 2023
nwneisen added a commit to nwneisen/cri-dockerd that referenced this pull request Jun 21, 2023
@nwneisen nwneisen deleted the MKE-9731-fix-cves branch January 21, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants