Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet dashboard #148

Merged
merged 49 commits into from
Jan 27, 2024
Merged

wallet dashboard #148

merged 49 commits into from
Jan 27, 2024

Conversation

M-Rb3
Copy link
Member

@M-Rb3 M-Rb3 commented Mar 4, 2022

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration(if any):

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@vercel
Copy link

vercel bot commented Mar 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/minorityprogrammers/mpa-webapp/BM85MHyuBfe3ER97HX58JERDdFfz
✅ Preview: https://mpa-webapp-git-wallet-dashboard-minorityprogrammers.vercel.app

@M-Rb3 M-Rb3 changed the title finished wallet dashboard wallet dashboard Mar 4, 2022
Copy link
Collaborator

@Ebube111 Ebube111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally the overall code looks good to me. Nice Job

Comment on lines +28 to 35
{/* <div
className="d-flex flex-row justify-content-between align-items-start"
style={{ height: '15%', width: '100%', marginBottom: '15px' }}
>
<p style={{ fontSize: '20px', fontWeight: '700', color: 'white' }}>
Currency Balances
</p>
<button type="button">Add Token</button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these code are no longer needed in the future then i suggest cleanup is needed or WDYT

Comment on lines +62 to +80
// {
// id: 4,
// name: 'Monero',
// symbol: 'XMR',
// price: 190.977911,
// price_btc: 1,
// market_cap: 180245643159,
// percent_change_24h: 1.41,
// percent_change_7d: -1.89,
// percent_change_30d: 4.73,
// color: 'orange',
// volume_24h: 26140524526.52,
// },
// {
// id: 5,
// name: 'Bitcoin Cash',
// symbol: 'BCH',
// price: 9798.977911,
// price_btc: 1,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as this page, if the code is not needed for later then i suggest cleanup

@ltran0817
Copy link
Collaborator

Since this dashboard was made for the light theme, the loading skeleton color I used was gray. For dark theme I suggest to use some light purple color to match it, or can use black since it goes well with everything. Other than that everything looks amazing to me!

Daebaks and others added 25 commits March 13, 2022 22:24
fixed casing+padding in core principles, fixed many typos+grammers, and removed NFT drop section and changed titles, as well as other statements per request.
added slider to core prionciples + fixed styles
@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
mpa-webapp ❌ Failed (Inspect) Sep 27, 2022 at 8:40PM (UTC)

@M-Rb3 M-Rb3 changed the base branch from main to chapter-page January 27, 2024 04:53
@M-Rb3 M-Rb3 merged commit c5e8a50 into chapter-page Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants