-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet dashboard #148
wallet dashboard #148
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/minorityprogrammers/mpa-webapp/BM85MHyuBfe3ER97HX58JERDdFfz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally the overall code looks good to me. Nice Job
{/* <div | ||
className="d-flex flex-row justify-content-between align-items-start" | ||
style={{ height: '15%', width: '100%', marginBottom: '15px' }} | ||
> | ||
<p style={{ fontSize: '20px', fontWeight: '700', color: 'white' }}> | ||
Currency Balances | ||
</p> | ||
<button type="button">Add Token</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these code are no longer needed in the future then i suggest cleanup is needed or WDYT
// { | ||
// id: 4, | ||
// name: 'Monero', | ||
// symbol: 'XMR', | ||
// price: 190.977911, | ||
// price_btc: 1, | ||
// market_cap: 180245643159, | ||
// percent_change_24h: 1.41, | ||
// percent_change_7d: -1.89, | ||
// percent_change_30d: 4.73, | ||
// color: 'orange', | ||
// volume_24h: 26140524526.52, | ||
// }, | ||
// { | ||
// id: 5, | ||
// name: 'Bitcoin Cash', | ||
// symbol: 'BCH', | ||
// price: 9798.977911, | ||
// price_btc: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as this page, if the code is not needed for later then i suggest cleanup
Since this dashboard was made for the light theme, the loading skeleton color I used was gray. For dark theme I suggest to use some light purple color to match it, or can use black since it goes well with everything. Other than that everything looks amazing to me! |
…esigned Consultancy page redesigned
changes needed ASAP cc-Shot
updated meta description
fixed casing+padding in core principles, fixed many typos+grammers, and removed NFT drop section and changed titles, as well as other statements per request.
added slider to core prionciples + fixed styles
fixed genadrop link
style updates
add unitmasters to partners
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration(if any):
Checklist: