Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow PCA dims == dims #59

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix: allow PCA dims == dims #59

merged 2 commits into from
Oct 3, 2024

Conversation

stephantul
Copy link
Collaborator

No description provided.

@stephantul stephantul requested a review from Pringled October 3, 2024 13:43
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
model2vec/distill/distillation.py 97.77% <100.00%> (+1.30%) ⬆️
tests/test_distillation.py 91.66% <ø> (ø)

@stephantul stephantul merged commit 78fce2e into main Oct 3, 2024
3 checks passed
@stephantul stephantul deleted the extra_gollum branch October 3, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant