Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Attention mask being None crashes distillation #58

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

stephantul
Copy link
Collaborator

No description provided.

@stephantul stephantul requested a review from Pringled October 3, 2024 09:39
@stephantul stephantul changed the title Fix nomic embed bug fix: Attention mask being None crashed distillation Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
model2vec/distill/inference.py 96.55% <100.00%> (+0.12%) ⬆️

@stephantul stephantul changed the title fix: Attention mask being None crashed distillation fix: Attention mask being None crashes distillation Oct 3, 2024
@stephantul stephantul merged commit 649ab51 into main Oct 3, 2024
3 checks passed
@stephantul stephantul deleted the fix_attention_mask_bug branch October 3, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant