Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update added tokens to be more agnostic #107

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

stephantul
Copy link
Collaborator

This fixes #106 .

We were overfitting on berttokenizer, apparently roberta has a different structure. this fix works for roberta and bert.

@stephantul stephantul self-assigned this Oct 23, 2024
@stephantul stephantul requested a review from Pringled October 23, 2024 07:54
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
model2vec/distill/tokenizer.py 73.21% <100.00%> (+0.48%) ⬆️

Copy link
Member

@Pringled Pringled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephantul stephantul merged commit 2f57b9c into main Oct 23, 2024
6 checks passed
@stephantul stephantul deleted the fix_added_tokens branch October 23, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'special_tokens'"
2 participants