Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maven endpoint + Jenkinsfile + upload task + add warning #774

Merged
merged 6 commits into from
Apr 28, 2021

Conversation

SizableShrimp
Copy link
Member

This is mainly for all the whiners out there. This PR is simple in what it does. I updated the maven endpoint to the new one, along with the Jenkinsfile and upload task used by Jenkins. I have no real way to test the Jenkinsfile, but I copied the one from FG4 and modified one line to use the correct gradle task for the older version. I also modified the actual upload task to use the modified variables. A warning is now spit out every time something relating to gradle is executed warning the user that the version is unsupported and they should upgrade or see the Forge discord for more info on helping. The exact message is:

WARNING: You are using an unsupported version of ForgeGradle.
Please consider upgrading to ForgeGradle 4 and helping in the efforts to get old versions working on the modern toolchain. See #mcpconfig in the Forge discord for more info.

Copy link

@CDAGaming CDAGaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see this likely being the last warning for <1.11.2 users (As 1.12.2 still works fine in FG4). LGTM

@LexManos
Copy link
Member

The entire point of the RetroGradle people, is to do that I did with 1.12.2, and make a MCPConfig/Update the Forge branches to build the userdevs. It is completely possible for FG4 to be used on ANY MC versions. It just takes someone putting in the effort. Which is why this is a call to people to help out. If they are so concerned about the old versions working still, they can spend some time helping upgrade the toolchain.

@MinecraftForge MinecraftForge deleted a comment from CDAGaming Apr 27, 2021
@LexManos
Copy link
Member

LexManos commented Apr 27, 2021

That was not an invitation to try and justify their argument. I have heard it all before, and it is all invalid. The decision has been made on how to address this. I was simply adding context to the warning message.

@LexManos LexManos merged commit f8745b3 into MinecraftForge:FG_2.3 Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants