Skip to content
This repository has been archived by the owner on May 26, 2018. It is now read-only.

Delay initialization of minecraft commands until after mod pre-init #498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yuuka-miya
Copy link
Contributor

This is a preparation PR to allow some features of MinecraftForge/MinecraftForge#1403

This PR delays the initialization of vanilla's commands, from before FML can startup its hooks into minecraft, to after the mod pre-initialization stage.

This will allow time for permission frameworks as specified in Forge pr 1403 to register themselves in the preinit stage, and thus will be available when the API registers permissions for vanilla commands.

{
this.func_71560_a(new CommandPublishLocalServer());
}
+ }public ServerCommandManager(){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue? You requested to keep patches small - that is what I did.

Yep, I kinda noopped 95% of the constructor, decided it was just better to cut it into 2 method bodies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that is horrible fucking code, do better.
Who in their right mind formats their code like that..
As for the rest of the permissions api, it'll get reviewed, last I looked it was sadly incomplete and i've stated that many many times which I don't want to repeat myself. So don't expect this pulled any time soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants