Move from CocoaPod to SPM #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamHFrancis
reviewed
Jan 20, 2022
| INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 8.2; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 12.2; |
There was a problem hiding this comment.
Was upping the minimum version necessary for SPM support?
| @@ -1,22 +0,0 @@ | |||
| # | |||
There was a problem hiding this comment.
Why remove cocoapods support?
| @@ -49,17 +49,17 @@ class CustomFontTests: XCTestCase { | |||
| //MARK: - Dynamic Type - Deprecated in iOS 11 | |||
|
|
|||
| func testOfStyle() { | |||
| let font = Futura.medium.of(style: .title3) | |||
| let font = Futura.medium.of(textStyle: .title3) | |||
There was a problem hiding this comment.
If we are removing support for < iOS 12, these tests can be deleted along with the deprecated of(style:) function.
|
|
||
| import PackageDescription | ||
|
|
||
| let package = Package( |
There was a problem hiding this comment.
Can we specify the test target in here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you'd like to keep CocoaPod support you can revert this commit: 399099c