Migrate to Swift 5️⃣.6️⃣ #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 92.24% 95.04% +2.79%
==========================================
Files 100 100
Lines 3367 3367
==========================================
+ Hits 3106 3200 +94
+ Misses 261 167 -94
Continue to review full report at Codecov.
|
diogoeiras
approved these changes
Jun 16, 2022
GH Actions' macOS 12 images have Xcode 13.4.1 available which means that Swift 5.6 is available to use in CI. https://github.com/actions/virtual-environments/blob/main/images/macos/macos-12-Readme.md#xcode ## Changes - Update `ci.yml`: + Use macOS image `macos-12` which contains Xcode 13.4.1. + Set `DEVELOPER_DIR` env var to point to Xcode 13.4.1. + Remove `IOS_SDK` env var so the latest SDK is used. + Update `swiftpm` job to use `xcodebuild` instead of `swift build`. as the latter now always compiles for the current architecture (macOS). + Replace `xcpretty` with `xcbeautify` in `xcodebuild` steps. - Make `Alicerce (SPM)` scheme public to use in CI's `swiftpm` job. - Update CocoaPods version in `Gemfile`. - Move Headers build phase before Compile sources in an attempt to fix "Cycle inside Alicerce;" error. - Silence SwiftLint warning in `Log.MultiLogger`. - Update Package.swift's `// swift-tools-version` to 5.6. - Update podspec's `swift_version` to 5.6. - Update `README.md`.
p4checo
force-pushed
the
migrate-to-swift-5-6
branch
from
1d3245e to
c4ef69b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
GH Actions' macOS 12 images have Xcode 13.4.1 available which means that Swift 5.6 is available to use in CI.
https://github.com/actions/virtual-environments/blob/main/images/macos/macos-12-Readme.md#xcode
Description
Update
ci.yml:macos-12which contains Xcode 13.4.1.DEVELOPER_DIRenv var to point to Xcode 13.4.1.IOS_SDKenv var so the latest SDK is used.swiftpmjob to usexcodebuildinstead ofswift buildas the latter now always compiles for the current architecture (macOS).xcprettywithxcbeautifyinxcodebuildsteps.Make
Alicerce (SPM)scheme public to use in CI'sswiftpmjob.Move Headers build phase before Compile sources in an attempt to fix "Cycle inside Alicerce;" error.
Silence SwiftLint warning in
Log.MultiLogger.Update cocoapods version in
Gemfile.Update Package.swift's
// swift-tools-versionto 5.6.Update podspec's
swift_versionto 5.6.Update
README.md.