Revise Boxes 📦
#249
Merged
Revise Boxes 📦
#249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems CI is breaking because it's using An official |
aclima93
reviewed
Jan 17, 2022
aclima93
approved these changes
Jan 18, 2022
We have had two `Box` variants for a very long time: `Box` and `VarBox`, containing an immutable and mutable value respectively. However, from our experience the immutable variant is not used often if at all, which means its immutability guarantee is not something that people want or need. Furthermore, following the latest language developments a `Box` is a very good candidate for a property wrapper, and more so now that they can be defined as local properties. ## Changes - Deprecate `VarBox` in favor of `Box`, making it wrap a mutable value. - Make `Box` a `@propertyWrapper`, and `@dynamicMemberLookup`. The latter is useful if we use `Box<T>` as a regular type (i.e. not a PW).
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=========================================
Coverage ? 92.02%
=========================================
Files ? 99
Lines ? 3284
Branches ? 0
=========================================
Hits ? 3022
Misses ? 262
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
We have had two
Boxvariants for a very long time:BoxandVarBox, containing an immutable and mutable value respectively.However, from our experience the immutable variant is not used often if at all, which means its immutability guarantee is not something that people want or need.
Furthermore, following the latest language developments a
Boxis a very good candidate for a property wrapper, and more so now that they can be defined as local properties.Description
Deprecate
VarBoxin favor ofBox, making it wrap a mutable value.Make
Boxa@propertyWrapper, and@dynamicMemberLookup. The latter is useful if we useBox<T>as a regular type (i.e. not a PW).