Improve EdgesConstrainableProxy API ↔️
#247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 94.94% 94.96% +0.02%
==========================================
Files 97 99 +2
Lines 3266 3280 +14
==========================================
+ Hits 3101 3115 +14
Misses 165 165
Continue to review full report at Codecov.
|
p4checo
force-pushed
the
feature/support-directional-insets-in-auto-layout
branch
from
ebb3d3f to
408b25b
Compare
p4checo
changed the title
NSDirectionalEdgeInsets in EdgesConstrainableProxy ↔️EdgesConstrainableProxy API ↔️
p4checo
force-pushed
the
feature/support-directional-insets-in-auto-layout
branch
2 times, most recently
from
1bea77e to
4764f26
Compare
Until now, it wasn't possible to define edges constraints using a `NSDirectionalEdgeInsets` value, requiring one to convert them to `UIEdgeInsets`. Additionally, the `EdgesConstrainableProxy.edges()` API only received a single `relation` and `priority` parameters for all edges, which is often not ideal in real scenarios. Some examples are: - allow a single edge constraint to "break"with a smaller `priority` and not others - allow edges to "shrink" towards the center, where the `relation` needs to be inverted between `leading`/`trailing` or `top`/`bottom`. To address the above, a new overload was added to `EdgesConstrainableProxy` that takes in a `NSDirectionalEdgeInsets` instance, and new edge-specific relation/priority parameters were added. ## Changes - Add a new `EdgesConstrainableProxy.edges` overload that receives a `NSDirectionalEdgeInsets` instance instead of a `UIEdgeInsets`. - Allow tweaking `relation` and `priority` for each edge of a `EdgesConstrainableProxy`. - Create helpers to convert between `UIEdgesInsets` and `NSDirectionalEdgesInsets`.
p4checo
force-pushed
the
feature/support-directional-insets-in-auto-layout
branch
from
4764f26 to
f05192b
Compare
aclima93
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
Until now, it wasn't possible to define edges constraints using a
NSDirectionalEdgeInsetsvalue, requiring one to convert them toUIEdgeInsets.Additionally, the
EdgesConstrainableProxy.edges()API only received a singlerelationandpriorityparameters for all edges, which is often not ideal in real scenarios. Some examples are:priorityand not othersrelationneeds to be inverted betweenleading/trailingortop/bottom.To address the above, a new overload was added to
EdgesConstrainableProxythat takes in aNSDirectionalEdgeInsetsinstance, and new edge-specific relation/priority parameters were added.Changes
Description
Add a new
EdgesConstrainableProxy.edgesoverload that receives aNSDirectionalEdgeInsetsinstance instead of aUIEdgeInsets.Allow tweaking
relationandpriorityfor each edge of aEdgesConstrainableProxy.Create helpers to convert between
UIEdgesInsetsandNSDirectionalEdgesInsets.