Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old UIView extensions for auto-layout constraints 📐 #237

Merged
merged 1 commit into from
May 20, 2021

Conversation

filipe-lemos
Copy link
Collaborator

Checklist

Motivation and Context

Alicerce has two types of auto-layout constraint helpers, these old
ones defined as extensions on UIView and also a newer, more powerful,
approach on the 'Auto-Layout' module.

Removing the old approach should avoid confusions and simplify the code
provided through Alicerce.

Description

  • Remove old UIView extensions for auto-layout constraints (and associated unit tests)

Alicerce has two types of auto-layout constraint helpers, these old
ones defined as extensions on `UIView` and also a newer, more powerful,
approach on the 'Auto-Layout' module.

Removing the old approach should avoid confusions and simplify the code
provided through Alicerce.
@filipe-lemos filipe-lemos requested a review from a team May 20, 2021 10:42
@filipe-lemos filipe-lemos self-assigned this May 20, 2021
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #237 (36d459d) into master (af7a9bc) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   94.99%   94.94%   -0.05%     
==========================================
  Files          97       96       -1     
  Lines        3296     3264      -32     
==========================================
- Hits         3131     3099      -32     
  Misses        165      165              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7a9bc...36d459d. Read the comment docs.

Copy link
Member

@p4checo p4checo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@filipe-lemos filipe-lemos merged commit aab56a3 into master May 20, 2021
@filipe-lemos filipe-lemos deleted the remove-old-constraints branch May 20, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants