Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions 🤖 #233

Merged
merged 3 commits into from
May 10, 2021
Merged

Migrate to GitHub Actions 🤖 #233

merged 3 commits into from
May 10, 2021

Conversation

p4checo
Copy link
Member

@p4checo p4checo commented May 7, 2021

Checklist

Motivation and Context

At long last, the time as come to say goodbye to Travis CI 👋.

All hail the new king, GitHub Actions 🙌

Description

  • Setup GitHub Action workflows:

    • ci.yml (Build + Test)
    • pod-lint (CocoaPods Lint)
    • release.yml (GitHub and CocoaPods releases)
    • spm.yml (SwiftPM Build)
  • Remove .travis.yml.

  • Add Gemfile and Gemfile.lock.

@p4checo p4checo requested a review from a team May 7, 2021 22:07
@p4checo p4checo force-pushed the migrate-to-github-actions branch 2 times, most recently from 2a2a918 to 3c0bca6 Compare May 7, 2021 22:49
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #233 (2cb9d7c) into master (1221eca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files          97       97           
  Lines        3296     3296           
=======================================
  Hits         3131     3131           
  Misses        165      165           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1221eca...2cb9d7c. Read the comment docs.

@p4checo p4checo force-pushed the migrate-to-github-actions branch 3 times, most recently from dacb620 to 0452352 Compare May 7, 2021 23:31
@p4checo p4checo removed the request for review from a team May 7, 2021 23:44
@p4checo p4checo force-pushed the migrate-to-github-actions branch 2 times, most recently from 200b89d to 0609dcc Compare May 7, 2021 23:56
At long last, the time as come to say goodbye to Travis CI 👋.

All hail the new king, GitHub Actions 🙌

## Changes

- Setup GitHub Action workflows:
  + `ci.yml` (Build + Test)
  + `pod-lint` (CocoaPods Lint)
  + `release.yml` (GitHub and CocoaPods releases)
  + `spm.yml` (SwiftPM Build)

- Remove .travis.yml.

- Add `Gemfile` and `Gemfile.lock`.
@p4checo p4checo force-pushed the migrate-to-github-actions branch from 0609dcc to c423d95 Compare May 8, 2021 00:05
@p4checo p4checo requested a review from a team May 8, 2021 00:19
Copy link

@pakerwreah pakerwreah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 💪🏻
I wonder how you're testing this, because there's a lot of stuff in there.
I would need like 100 commits on a draft PR to get this working.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@diogoeiras
Copy link
Contributor

✨🤖

@p4checo
Copy link
Member Author

p4checo commented May 8, 2021

@pakerwreah haha

I'm testing it in this PR, actually. Not 100 commits but at least 10 I've made already (via force pushes, so no one sees my mess) 😇

I can't also take full credit, because I had the luck to get some inspiration elsewhere and simply adapted to our case 🤫

@p4checo p4checo force-pushed the migrate-to-github-actions branch 3 times, most recently from 4b2cab1 to a8e36e7 Compare May 8, 2021 22:49
@p4checo
Copy link
Member Author

p4checo commented May 10, 2021

Well, it appears that workflows that depend on other workflows (like release.yml) are only ran once they are present in master/main (I've done that experiment on a different repo, to avoid more push spam).

So, I think that we have to merge this and then test to see if the Release workflow is working as expected 🍀🙏🏼 🕯️

Additionally, there's something not working with the codecov github action (codecov/codecov-action@v1), but the remote script works. Will give it another go with v1.5 (latest) and if that doesn't work I'll leave the script and move on

@p4checo p4checo force-pushed the migrate-to-github-actions branch from a8e36e7 to 9f84e1e Compare May 10, 2021 12:16
@p4checo p4checo merged commit 9e402a9 into master May 10, 2021
@p4checo p4checo deleted the migrate-to-github-actions branch May 10, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants