Simplify Analytics.MultiTracker 👁
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While our `Analytics.MultiTracker` was implemented to be dynamically configured by allowing registering/unregistering sub trackers, in reality this didn't bring much benefit (or at all) as from our experience the tracker is typically configured once during app startup. To allow this dynamism while being thread safe, it resorted to synchronization primitives (i.e. `Atomic`) on the state, which in practice causes one lock/unlock per track call (trackers). This is obviously a very high price to pay when we consider that the dynamism it allows is rarely used. So, this dynamism has been removed in favor of configuring the tracker once on `init`, passing in the sub-trackers to use. Additionally, some some minor improvements were made to Analytics related types. ## Changes - Make `Analytics.MultiTracker` have its sub-trackers be configured on `init`, avoiding complexity and contention due to handling concurrent operations. - Remove `ID` from `AnalyticsTracker`, as it was used mostly to keep track of registered trackers. - Add `eraseToAnyAnalyticsRracker()` helper in `AnalyticsTracker` to facilitate type erasing trackers to passinto `Analytics.MultiTracker`s. - Add `_wrapped` helper property in `AnyAnalyticsTracker` to hold a reference to the wrapped tracker instance.
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 94.98% 94.95% -0.03%
==========================================
Files 97 97
Lines 3267 3252 -15
==========================================
- Hits 3103 3088 -15
Misses 164 164
Continue to review full report at Codecov.
|
nbarreto6
approved these changes
Apr 5, 2021
filipe-lemos
approved these changes
Apr 5, 2021
diogoeiras
approved these changes
Apr 6, 2021
aclima93
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
While our
Analytics.MultiTrackerwas implemented to be dynamically configured by allowing registering/unregistering sub trackers, in reality this didn't bring much benefit (or at all) as from our experience the tracker is typically configured once during app startup. To allow this dynamism while being thread safe, it resorted to synchronization primitives (i.e.Atomic) on the state, which in practice causes one lock/unlock per track call (trackers). This is obviously a very high price to pay when we consider that the dynamism it allows is rarely used. So, this dynamism has been removed in favor of configuring the tracker once oninit, passing in the sub-trackers to use.Additionally, some some minor improvements were made to
Analyticsrelated types.Description
Make
Analytics.MultiTrackerhave its sub-trackers be configured oninit, avoiding complexity and contention due to handling concurrent operations.Remove
IDfromAnalyticsTracker, as it was used mostly to keep track of registered trackers.Add
eraseToAnyAnalyticsRracker()helper inAnalyticsTrackerto facilitate type erasing trackers to passintoAnalytics.MultiTrackers.Add
_wrappedhelper property inAnyAnalyticsTrackerto hold a reference to the wrapped tracker instance.