Rename KeyboardObserver private funcs
#226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to a message received from App Store Connect, `keyboardDidHide` and `keyboardDidShow` are methods that match the private Apple APIs. The solution should pass by renaming said methods. - Rename `keyboardDidHide` and `keyboardDidShow` to `keyboardBecameVisible` and `keyboardBecameInvisible` respectively
nqtavares
approved these changes
Dec 4, 2020
literallysofia
approved these changes
Dec 4, 2020
filipe-lemos
approved these changes
Dec 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 97 97
Lines 3267 3267
=======================================
Hits 3103 3103
Misses 164 164
Continue to review full report at Codecov.
|
p4checo
approved these changes
Dec 4, 2020
nbarreto6
approved these changes
Dec 4, 2020
ivopintodasilva
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
According to a message received from App Store Connect,
keyboardDidHideandkeyboardDidShoware methods that match the private Apple APIs. The solution should pass by renaming said methods.Description
keyboardDidHideandkeyboardDidShowtokeyboardBecameVisibleandkeyboardBecameInvisiblerespectivelyObservation: we could opt for other names like
onKeyboardDidHideorreceivedKeyboardDidHideNotification