Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing public init to StackOrchestrator.FetchResource #225

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

filipe-lemos
Copy link
Collaborator

Checklist

Motivation and Context

StackOrchestrator.FetchResource is missing its public init only having the synthesized internal init.

Description

StackOrchestrator.FetchResource needs to be inited as it's the typealias for StackOrchestratorStore.Resource and necessary as a parameter on StackOrchestratorStore.fetch(resource:completion:). No helpers or alternative methods seem to be available for instantiating the struct so the absence of the explicit init is most likely an oversight.

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #225 (40b4192) into master (7701fb5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   94.97%   94.98%           
=======================================
  Files          97       97           
  Lines        3263     3267    +4     
=======================================
+ Hits         3099     3103    +4     
  Misses        164      164           
Impacted Files Coverage Δ
Sources/StackOrchestrator/StackOrchestrator.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7701fb5...40b4192. Read the comment docs.

Copy link
Member

@p4checo p4checo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Days since I forgot a public init: 0 😅

- Add missing newline
@filipe-lemos filipe-lemos merged commit a91b127 into master Nov 13, 2020
@p4checo p4checo deleted the bugfix/networking-public-init branch November 14, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants