Lk86/resolve rosetta conflicts #9932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds explicit invalid transaction errors to Rosetta. Sadly, due to the way we raise these errors in GraphQL it's hacky and relies on substring search. Where relevant, I've added comments to the strings in the daemon that we rely on for this code to continue working. In the future, we should refactor the GraphQL submit code path to understand errors more explicitly rather than relying on strings. All failure modes were reproduced by manually manipulating test-curl/ scripts and GraphQL error strings were inspected to create the patterns seen in this PR. After implementing the changes, I tested a few again to make sure they were parsing properly.
This reverts commit 80aeeff.
This reverts commit 68360c5.
…er in the background
We hope this fixes the memory errors Note: This is the first commit specifically on this branch for the first time and not a cherry-pick
Bump the concurrency up to 64 as 16 is too slow
The rosetta side of the equation
…us-fast-archive
Make sure the recursive query stops before going too far, and fallback to the historical query in that case with (min_recent_height-1)
This reverts commit 3982e63.
We also need to release a new version of the client-sdk
…etwork-endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.