Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crypto][kimchi] stubs + backend for kimchi #9547

Merged
merged 125 commits into from
Jan 9, 2022
Merged

[crypto][kimchi] stubs + backend for kimchi #9547

merged 125 commits into from
Jan 9, 2022

Conversation

mimoo
Copy link
Contributor

@mimoo mimoo commented Oct 2, 2021 •
edited
Loading

This PR introduces kimchi (formerly known as 15-wires) to the OCaml side:

src/lib/crypto/
├── kimchi_backend/ # the backend to integrate kimchi with pickles
└── kimchi_bindings/ # the stubs and OCaml bindings for kimchi

The OCaml-side of the bindings are now generated automatically via ocaml-gen. You can also generate them by hand:

$ cd src/lib/crypto/kimchi_bindings/stubs
$ cargo run --manifest-path binding_generation/Cargo.toml

What's this?

This is part of integrating Kimchi into Mina

Screen Shot 2021-10-14 at 6 01 12 PM

TODO

  • make kimchi_backend build
  • delete zexe_backend

@mimoo mimoo requested review from a team as code owners October 2, 2021 01:08
@mimoo mimoo changed the base branch from develop to mimoo/marlin4 October 2, 2021 01:08
@mimoo mimoo mentioned this pull request Oct 2, 2021
Closed
9 tasks
@mimoo mimoo changed the title [WIP][crypto] create stubs for 15-wires [crypto] create stubs for kimchi Oct 7, 2021
@mimoo mimoo mentioned this pull request Oct 7, 2021
Merged
@mimoo mimoo mentioned this pull request Oct 7, 2021
Merged
@joseandro joseandro mentioned this pull request Oct 8, 2021
Closed
@joseandro joseandro linked an issue Oct 8, 2021 that may be closed by this pull request
[kimchi] implement Rust stubs #9572
Closed
@mimoo mimoo changed the title [crypto] create stubs for kimchi [crypto][kimchi] stubs + backend for kimchi Oct 13, 2021
mimoo
mimoo commented Dec 17, 2021
View reviewed changes
src/lib/crypto/kimchi_bindings/stubs/src/caml/caml_bytes_string.rs
use ocaml::{FromValue, IntoValue, Runtime, Value};
use ocaml_gen::{const_random, Env, OCamlDesc};

pub struct CamlBytesString<'a>(pub &'a [u8]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can live with this :) can you add some doc to explain why we have this struct here? Otherwise perfect!

@mrmr1993 mrmr1993 merged commit 205c4a9 into feature/kimchi Jan 9, 2022
@mrmr1993 mrmr1993 deleted the mimoo/backend branch January 9, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeckler imeckler imeckler approved these changes

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[kimchi] implement Rust stubs
3 participants
@mimoo @imeckler @mrmr1993