Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use terraform workspaces for managing CI deployment states #7710

Merged
merged 11 commits into from
Jan 29, 2021

Conversation

O1ahmad
Copy link
Contributor

@O1ahmad O1ahmad commented Jan 28, 2021

terraform workspace basically allows management of multiple related states via a single state file (see for more details).

Also reduce time after apply to destroy deployment during DeployAndDestroy test and add a variable for the path for testnet artifacts to be stored/processed locally.

Test: Buildkite CI

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #7701

@O1ahmad O1ahmad requested a review from a team as a code owner January 28, 2021 16:54
@O1ahmad O1ahmad changed the base branch from develop to compatible January 28, 2021 16:54
@O1ahmad O1ahmad added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jan 28, 2021
esac
shift
done

# if override not provided, default to testnets DIR
if [[ ! $ARTIFACT_PATH ]]; then
ARTIFACT_PATH="terraform/testnets/${TESTNET}/"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove trailing '/'

@O1ahmad O1ahmad force-pushed the deploy_testnet_workspaces branch from a4c5d36 to e85577f Compare January 29, 2021 03:25
@O1ahmad O1ahmad merged commit f1780fc into compatible Jan 29, 2021
@O1ahmad O1ahmad deleted the deploy_testnet_workspaces branch January 29, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants