Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivial] Add commit_id to error_to_json #7693

Merged
merged 1 commit into from
Jan 26, 2021
Merged

[Trivial] Add commit_id to error_to_json #7693

merged 1 commit into from
Jan 26, 2021

Conversation

mrmr1993
Copy link
Member

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #7647

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jan 26, 2021
@mrmr1993 mrmr1993 requested a review from a team as a code owner January 26, 2021 22:34
@mrmr1993 mrmr1993 changed the base branch from develop to compatible January 26, 2021 22:48
@mrmr1993 mrmr1993 merged commit f5c58ee into compatible Jan 26, 2021
@mrmr1993 mrmr1993 deleted the feature/commit-id-in-error-json branch January 26, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthiskumar deepthiskumar deepthiskumar approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print commit ID in the exception JSON printer
2 participants
@mrmr1993 @deepthiskumar