log file for rejected blocks #7605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepthiskumar
added
the
ci-build-me
|
Will the new file also show up in coda client export-logs and -export-local-logs ? |
Yup, any file with substring |
mrmr1993
reviewed
Jan 22, 2021
| ~processor:(Logger.Processor.raw ()) | ||
| ~transport: | ||
| (Logger.Transport.File_system.dumb_logrotate ~directory:conf_dir | ||
| ~log_filename:"mina-best-tip.log" ~max_size:best_tip_diff_log_size | ||
| ~num_rotate:1) ; | ||
| let rejected_blocks_log_size = 1024 * 1024 * 5 in |
There was a problem hiding this comment.
It might be more elegant (and easier to use again in future etc.) to add the concept of Logger_id.t extensions to Logger.Consumer_registry, so that this logger could accept messages and write them to its file but also pass them to the standard logger automatically too.
There was a problem hiding this comment.
Agreed, is it ok if I follow it up in another PR?
mrmr1993
approved these changes
Jan 22, 2021
nholland94
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A separate log file
mina-rejected-blocks.logfor rejected blocks. This is to understand the impact of blocks being missed/not broadcasted fast enough(tracked here #7338)