Height input to block query #7592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkase
approved these changes
Jan 21, 2021
src/lib/mina_graphql/mina_graphql.ml
Outdated
| (fun {ctx= coda; _} () (state_hash_base58_opt : string option) | ||
| (height_opt : int option) -> | ||
| let have_state_hash = Option.is_some state_hash_base58_opt in | ||
| let have_height = Option.is_some height_opt in |
There was a problem hiding this comment.
nit: I think this function would be cleaner using a pattern match on (state_hash_opt, height_opt), then you won't need the value_exn later.
As written, it looks correct to me. But I'm worried that future edits to this function could introduce crashes accidentally when we're relying on the value_exns.
But I won't block the PR on it -- if you do want to change it, let me know and I'll look at it again
psteckler
added
ci-build-me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
heightargument to QraphQLblockquery.With this change, the query requires exactly one of
heightorstateHash(allowing both would not be sensible, I think).Tested against a local network.