Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Peer_banned structured log message #7017

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Fix Peer_banned structured log message #7017

merged 2 commits into from
Dec 10, 2020

Conversation

mrmr1993
Copy link
Member

This fixes a crash by renaming the peer field to sender_id, so that it matches ban_message . See e.g. https://buildkite.com/o-1-labs-2/mina/builds/7332#b2ac1ae0-5e43-4b0f-8df9-b0fecfcdd27d

We should might have been able to catch this in ppx_register_event, which is far preferable to a crash a runtime. @psteckler any ideas?

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 requested a review from a team as a code owner December 10, 2020 14:54
@mrmr1993 mrmr1993 added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop labels Dec 10, 2020
@psteckler psteckler mentioned this pull request Dec 10, 2020
Merged
@mergify mergify bot merged commit 81ac615 into develop Dec 10, 2020
@mergify mergify bot deleted the fix/would-ban-log-message branch December 10, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteckler psteckler psteckler approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @psteckler