Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block production/gossip logs at info level #6973

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Block production/gossip logs at info level #6973

merged 2 commits into from
Dec 7, 2020

Conversation

deepthiskumar
Copy link
Member

@deepthiskumar deepthiskumar commented Dec 7, 2020 •
edited
Loading

Log the following at info level

  1. "Received a block from"
  2. "Broadcasting new state over gossip net"
  3. "Rebroadcasting $state_hash"
  4. "Producing new block with parent $breadcrumb"
  5. "Successfully produced a new block"

Also removed the daemon flag -log-received-blocks. The daemon will always log blocks received

The reason for this PR is to have enough information about block production and gossip in the log files to calculate block latencies as implemented here https://github.com/MinaProtocol/coda-automation/pull/509

@deepthiskumar deepthiskumar requested a review from a team as a code owner December 7, 2020 20:30
@mrmr1993 mrmr1993 added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop labels Dec 7, 2020
@mergify mergify bot merged commit 9e79c6b into develop Dec 7, 2020
@mergify mergify bot deleted the fix/block-related-logs-info branch December 7, 2020 23:27
@deepthiskumar deepthiskumar mentioned this pull request Dec 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepthiskumar @mrmr1993