Interrupt Transaction_pool.apply when the ledger is detached #6971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
detach_signal
method to ledgers triggered whenInterruptible.Deferred_let_syntax
Let_syntax
module that works with ppx_let to consumeAsync.Deferred.t
s and returnInterruptible.t
slet%map_open
/let%bind_open
, where the rhs of the binding can use theDeferred.t
monad as normal.Transaction_pool.apply
to interrupt when its ledger emits a detach signaldetach_signal
and theInterruptible.Deferred_let_syntax
to trigger the interrupt with minimal code changesOpen question: should we re-run the
apply
when it has been interrupted? As currently written, we treat it as a bad diff.Checklist:
Closes #6946