Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/libp2p async (from 4.1-turbo-pickles failed merge) #6892

Merged
merged 6 commits into from
Dec 2, 2020
Merged

Hotfix/libp2p async (from 4.1-turbo-pickles failed merge) #6892

merged 6 commits into from
Dec 2, 2020

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Dec 1, 2020

This PR is part of #6876.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Dec 1, 2020
@mrmr1993 mrmr1993 requested a review from a team as a code owner December 1, 2020 18:28
mrmr1993
mrmr1993 commented Dec 2, 2020
View reviewed changes
Copy link
Member Author

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@nholland94 nholland94 changed the base branch from develop to develop-until-4.1-hardfork December 2, 2020 18:45
@nholland94 nholland94 changed the base branch from develop-until-4.1-hardfork to develop December 2, 2020 18:48
@mergify mergify bot merged commit c7e1a19 into develop Dec 2, 2020
@mergify mergify bot deleted the hotfix/libp2p-async branch December 2, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nholland94 nholland94 nholland94 approved these changes

Assignees

@nholland94 nholland94

Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @nholland94