Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating submodule coda-automation to branch master #6891

Merged
merged 8 commits into from
Dec 1, 2020
Merged

Updating submodule coda-automation to branch master #6891

merged 8 commits into from
Dec 1, 2020

Conversation

lk86
Copy link
Contributor

@lk86 lk86 commented Dec 1, 2020

Thank you for contributing to Coda! Please see CONTRIBUTING.md if you haven't
yet. In that doc, there are more details around how to start our CI.

Explain your changes here.

Explain how you tested your changes here.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #0000
Closes #0000

@lk86 lk86 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Dec 1, 2020
@lk86 lk86 requested a review from a team as a code owner December 1, 2020 17:30
mrmr1993
mrmr1993 approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but see comment

@lk86 lk86 merged commit 8c6d9ae into develop Dec 1, 2020
@lk86 lk86 deleted the fix-peers-develop branch December 1, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@O1ahmad O1ahmad O1ahmad approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lk86 @mrmr1993 @O1ahmad