pulling subscription bug #6880
Closed
pulling subscription bug #6880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmr1993
reviewed
Dec 1, 2020
| let maybe_sig_d = | ||
| let w : ('a, 's) Deferred.Result.t = | ||
| Deferred.any [t.d; interruption_signal_to_res] | ||
| match Deferred.peek t.interruption_signal with |
There was a problem hiding this comment.
This behaviour of interruptible is better, but I'm still not sure that it's right. I've opened #6889 to implement (what I consider to be) the correct behaviour.
|
closing bc apparently mathew has a better solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the integration testing framework, the async threads that pull from GCP's pub/sub system continue to run even after those pub/sub resources are destroyed in the cleanup, which causes errors. this needs to be fixed