Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version info when exporting logs and coda version #6857

Merged
merged 2 commits into from
Nov 25, 2020
Merged

version info when exporting logs and coda version #6857

merged 2 commits into from
Nov 25, 2020

Conversation

deepthiskumar
Copy link
Member

  1. coda version to show the entire commit hash
  2. changes to the export log functionality:
    1. include coda.version
    2. include all the log files

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@deepthiskumar deepthiskumar requested a review from a team as a code owner November 25, 2020 21:26
@deepthiskumar deepthiskumar added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop labels Nov 25, 2020
@mergify mergify bot merged commit b5967c1 into develop Nov 25, 2020
@mergify mergify bot deleted the fix/version-info branch November 25, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@lk86 lk86 lk86 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepthiskumar @mrmr1993 @lk86