Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Connects to Testnet Test #6836

Merged
merged 23 commits into from
Nov 24, 2020
Merged

CI Connects to Testnet Test #6836

merged 23 commits into from
Nov 24, 2020

Conversation

bkase
Copy link
Member

@bkase bkase commented Nov 23, 2020

Add test for connecting build to testnet on PR

Closes #6737

@bkase bkase requested a review from a team as a code owner November 23, 2020 22:41
@bkase bkase added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 23, 2020
mrmr1993 and others added 16 commits November 23, 2020 23:12
@mrmr1993
chmod +x buildkite/scripts/connect-to-testnet-on-develop.sh
caf2b3e
@mrmr1993
No sudo
79a4cbf
@bkase
Install git before sourcing env vars
75ef335
@mrmr1993
Add missing DUNE_PROFILE
637d647
@mrmr1993
apt-get install doesn't accept the .deb file extension
aa111c1
@mrmr1993
apt-get install format is package=version
f6ef0d7
@mrmr1993
Debconf: Don't prompt for answers during apt-get
11ebb4b
@mrmr1993
Pull config from github if there is no local coda-automation checkout
c238b32
@mrmr1993
Make startup more flexible
0b922dc
@mrmr1993
Start daemon in shell background task instead of daemonising
fd498c8
@mrmr1993
Remove lockfile if present
c136730
@mrmr1993
get-peers is under advanced, not client
74983f5
@mrmr1993
Merge branch 'develop' into feature/ci-connect-to-testnet
b0f069f
@mrmr1993
Use a for loop and break instead of manual unrolling
3f98010
@mrmr1993
Merge branch 'feature/ci-connect-to-testnet' into feature/ci-connect-…
565ae69 
…to-testnet
@mrmr1993
Fail if none of the 'client status' calls are successful
5f02428
O1ahmad
O1ahmad approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@O1ahmad O1ahmad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, lg2m - may want to add a softFail now or later for when there aren't active testnets(/the connect test is expected to fail)

@mergify mergify bot merged commit 011c625 into develop Nov 24, 2020
@mergify mergify bot deleted the feature/ci-connect-to-testnet branch November 24, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@O1ahmad O1ahmad O1ahmad approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup develop for stable chain id
3 participants
@bkase @O1ahmad @mrmr1993