Fixes for turbo pickles (should improve catchup) #6822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bkase
approved these changes
Nov 22, 2020
| in | ||
| Envelope.Incoming.wrap_peer ~data:transition_with_hash | ||
| ~sender:peer ) ) ) | ||
| Hash_set.remove busy peer ; |
There was a problem hiding this comment.
should you add a remove call in a finally or something in case there's an exception?
There was a problem hiding this comment.
Yes gp -- do you know how to do that?
There was a problem hiding this comment.
Wrapping the rhs of the binding above in a Deferred.Or_error.try_with should catch any errors, will mean that this call is always run.
imeckler
added
ci-build-me
…ying to add completed work
…a into fixes-for-turbo-pickles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a number of fixes for the current test network. It should improve catchup in that it changes the way that blocks are downloaded to be more efficient/effective. It does not fully fix all the issues but it should get us a lot closer.