Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test--dev--coda-archive-node-test #6814

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Fix test--dev--coda-archive-node-test #6814

merged 2 commits into from
Nov 23, 2020

Conversation

mrmr1993
Copy link
Member

This PR

  • fixes the test, by not checking for blocks that could never have been seen
  • uses [%test_eq] instead of assert to check equality, so that the results of a failure are printed.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 requested a review from a team as a code owner November 21, 2020 07:24
@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 21, 2020
@psteckler psteckler added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Nov 23, 2020
@mergify mergify bot merged commit 71c20ac into develop Nov 23, 2020
@mergify mergify bot deleted the feature/fix-archive-node-test branch November 23, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteckler psteckler psteckler approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @psteckler