Add ppx_version support to allocation functor; use in more places #6781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nholland94
added
ci-build-me
mrmr1993
approved these changes
Nov 19, 2020
src/lib/allocation_functor/make.ml
Outdated
Comment on lines
20
to
23
| (* TODO: does these last two need wrapped as well? *) | ||
| let bin_reader_t = M.bin_reader_t | ||
|
|
||
| let bin_t = M.bin_t |
There was a problem hiding this comment.
As mentioned on discord, we should just bundle these up as needed:
let bin_reader_t = { read = bin_read_t; vtag_read = __bin_read_t__ }
let bin_t = { shape = bin_shape_t; writer = bin_writer_t; reader = bin_reader_t }The Bin_prot.Utils.Of_minimal functor should also do this for you, if you'd prefer that route.
…oned' into feature/allocation-functor-versioned
mrmr1993
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6719