Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow keys, urs to be appended to a file instead of overwriting #6773

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Allow keys, urs to be appended to a file instead of overwriting #6773

merged 2 commits into from
Nov 20, 2020

Conversation

mrmr1993
Copy link
Member

This PR adds an optional append argument to the rust write functions, to allow us to place a header before the actual data in the file. This is the counterpart to #6771, which adjusts the read functions.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 19, 2020
@mrmr1993 mrmr1993 requested a review from a team as a code owner November 19, 2020 19:41
Base automatically changed from feature/rust-parse-after-header to develop November 19, 2020 19:53
@mergify mergify bot merged commit b323fa5 into develop Nov 20, 2020
@mergify mergify bot deleted the feature/rust-write-after-header branch November 20, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeckler imeckler imeckler approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @imeckler