Fix CI for external contributors: rosetta docker build failure #6758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that pull requests from external contributors -- where the pull request repo is not the mina main repo -- will still be able to build the rosetta docker image, by directing the clone at their repo instead
This should only be an issue on older versions of docker, but better safe than sorry.
mrmr1993
added
the
ci-build-me
lk86
approved these changes
Nov 20, 2020
bkase
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the CI step to pass the requesting repo for pull requests, so that the clone operation points at the correct repo.
When the run is not a pull request -- for example, hourly develop builds -- the
BUILDKITE_PULL_REQUEST_REPOenvironment variable will be set to the empty string. Omitting the newMINA_REPOargument or passing the empty string will fall back to the main repo.Checklist: