Use Error.tag/tag_arg instead of stringifying errors #6751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces some
Error.to_string_hum
withError.tag
andError.tag_arg
. These add additional data to errors without forcing their format, and play much more nicely with our pretty-printing in the logger.A few uses still remain, mostly where the error is passed through calls between being cast to a string and being re-cast to an error. These are few and can be done as follow-up work at some later time.
Checklist:
Closes #6699