Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for external contributors #6747

Merged
merged 4 commits into from
Nov 25, 2020

Conversation

mrmr1993
Copy link
Member

This PR

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

This allows buildkite to function correctly on forked pull requests, by
telling it which repository the pull request came from.

Tested successfully (manually) on PR #6703.
@mrmr1993 mrmr1993 requested a review from bkase November 18, 2020 04:47
@mrmr1993 mrmr1993 requested a review from a team as a code owner November 18, 2020 04:47
@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 18, 2020
@mrmr1993
Copy link
Member Author

Updated to improve logging.

After debugging, it turns out that the user making the comment needs to publically be a member of the org. At present, this means that only @bkase and I can trigger CI jobs with the !ci-build-me comment.

@mrmr1993
Copy link
Member Author

Merging, this has been deployed for a week working correctly and without issue.

@mrmr1993 mrmr1993 merged commit 93f699e into develop Nov 25, 2020
@mrmr1993 mrmr1993 deleted the feature/fix-ci-for-external-contributors branch November 25, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant