Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mina_user_error for daemon bootup failures #6741

Merged
merged 14 commits into from
Nov 19, 2020

Conversation

mrmr1993
Copy link
Member

This PR converts the configuration errors that users may see during startup to use Mina_user_error. This gives us consistent pretty-printing for them all.

Notes:

  • Several of these come from the Secrets library; I have reworked the errors there to have a more consistent format, to always identify which key-type the error is for, and to use Mina_user_error.
  • There is some additional error handling in a few places where we could have encountered an exception without handling it.
  • The Mina_user_error.Mina_user_error exception registers a printer so that the message is pretty-printed even when it is emitted outside of the daemon command (e.g. some of the Secrets errors may appear in accounts commands).

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 requested a review from a team as a code owner November 18, 2020 00:12
@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 18, 2020
@mrmr1993 mrmr1993 linked an issue Nov 18, 2020 that may be closed by this pull request
@mrmr1993 mrmr1993 linked an issue Nov 18, 2020 that may be closed by this pull request
Copy link
Member

@nholland94 nholland94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit 1caa2d0 into develop Nov 19, 2020
@mergify mergify bot deleted the feature/pretty-daemon-bootup-failures branch November 19, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add raise_user_error function and utilize in daemon bootup failures Invalid Keypair Permissions Crash
3 participants