Fix libp2p initial peers RPC is triggered now #6702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkase
added
the
ci-build-me
mrmr1993
approved these changes
Nov 13, 2020
| @@ -1122,7 +1115,7 @@ func main() { | |||
| logging.SetLogLevel("autorelay", "info") // Logs relayed byte counts spammily | |||
| logging.SetLogLevel("providers", "debug") | |||
| logging.SetLogLevel("dht/RtRefreshManager", "warn") // Ping logs are spammy at debug, cpl logs are spammy at info | |||
| logging.SetLogLevel("dht", "info") // Logs every operation to debug | |||
| logging.SetLogLevel("dht", "debug") // Logs every operation to debug | |||
There was a problem hiding this comment.
Will we want to leave these logs enabled, or is this just for testing? It's nice to not have the logspam if we aren't going to be using them.
mrmr1993
reviewed
Nov 13, 2020
| @@ -1122,7 +1115,6 @@ func main() { | |||
| logging.SetLogLevel("autorelay", "info") // Logs relayed byte counts spammily | |||
| logging.SetLogLevel("providers", "debug") | |||
| logging.SetLogLevel("dht/RtRefreshManager", "warn") // Ping logs are spammy at debug, cpl logs are spammy at info | |||
| logging.SetLogLevel("dht", "info") // Logs every operation to debug | |||
There was a problem hiding this comment.
Can you re-add this? This sets the minimum level, so deleting it shows all logs from the subsystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries triggering RPC for real with foundPeer on connect and disconnect
EDIT: Tested on
peeringnetwork (which partially deployed). Confirmed that (1) the network peers metric increases (this means the callback is called properly). (2) the get some initial peers call is happening (3) it is successfully sending peers back to those that join on first connect and (4) there are no errors when trying to add those peers.